This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Add InMemoryVersionedBackend #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Is it possible to have a feedback please? Thanks in advance |
|
Would love to see this merged |
|
Definitely need this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Quick PR to be able to do some Versioning (only for InMemory usage) by simply enabling the InMemoryVersionedBackend like this :
S3Mock api = new S3Mock.Builder().withPort(8001).withInMemoryVersionedBackend().build();InMemoryVersionedProviderwas really close toInMemoryProvidersoAbstractInMemoryProviderwas added for abstractionAlso written some test cases
It's my first time doing Scala so do not hesitate to share your input.
I really appreciate this project really helpfull in for tests, however versioning will be a big plus for us as it's really needed in my current project.
Thanks in advance
furkilic
Linked to #155